Results for "" :: SourceMod

11

SQL error in plugin, help ?

The reason string (char array in sourcemod) is not populated when the g_hReasonsConvar is set to 0. Argument number 6 in the format() function is the reason string. It's trying to create a string from an uninitialised variable. You're not allowed to do this.

Replace all instances of this:

if (GetConVarBool(g_hReasonsConvar)) { if (args > 2) { for (int i = 3; i <= args; i++) { char temp[32]; GetCmdArg(i, temp, sizeof(temp)); Format(arg3, sizeof(arg3), "%s %s", arg3, temp); } } else Format(arg3, sizeof(arg3), "No Reason Given"); }

With this instead. It should resolve the problem for all commands.

if (GetConVarBool(g_hReasonsConvar)) { if (args > 2) { for (int i = 3; i <= args; i++) { char temp[32]; GetCmdArg(i, temp, sizeof(temp)); Format(arg3, sizeof(arg3), "%s %s", arg3, temp); } } else Format(arg3, sizeof(arg3), "No Reason Given"); } else Format(arg3, sizeof(arg3), "");

The DEFAULT keyword in MySQL is for when no value is entered into the table. This does not apply here because there will always be an amount sent via the commands. It is present in case the plugin is changed, so there will not be a resulting MySQL error if no amount is sent. It's best to keep this number at 0, so there will be no impact on the tables in this scenario.

It looks like you may have changed the plugin. The Line numbers do not correspond with the forum version. I require your version of the plugin to see why AddReputation doesn't work.

bool g_DatabaseIsConnected = false; public void OnDatabaseConnect(Handle owner, Handle hndl, const char[] error, any data) { if (hndl == INVALID_HANDLE) { LogError("Failed to connect! Error: %s", error); PrintToServer("Failed to connect: %s", error); SetFailState("Failed to connect, SQL Error: %s", error); return; } db = hndl; g_DatabaseIsConnected = true; SQL_CreateTables(); } public void OnClientPostAdminCheck(int client) { if (!g_DatabaseIsConnected) return; if (db == INVALID_HANDLE) SetFailState("Failed to connect, SQL Error"); if(!IsValidClient(client)) return; CountRep(client); char sQuery[1256]; char client_steamID[64]; if (!GetClientAuthId(client, AuthId_Engine, client_steamID, sizeof(client_steamID))) return; if (!GetConVarBool(g_hMultipleRepsConvar)) { for (int i; i < MaxClients; i++) { if (!IsValidClient(i)) continue; char i_SteamID[64]; if (!GetClientAuthId(i, AuthId_Engine, i_SteamID, sizeof(i_SteamID))) continue; Handle dp = CreateDataPack(); WritePackCell(dp, client); WritePackCell(dp, i); canRep[client] = true;

Format(sQuery, sizeof(sQuery), "SELECT COUNT(*) FROM `reputation` WHERE `giver_steamid` = \"%s\" AND `recipient_steamid` = \"%s\"", client_steamID ,i_SteamID);
SQL_TQuery(db, SQL_MultipleRepCheck, sQuery, dp);

canRep[client] = true;

Format(sQuery, sizeof(sQuery), "SELECT COUNT(*) FROM `reputation` WHERE `giver_steamid` = \"%s\" AND `recipient_steamid` = \"%s\"", i_SteamID, client_steamID);
SQL_TQuery(db, SQL_MultipleRepCheck, sQuery, dp);
}
}

if (GetConVarBool(g_hConnectAnnounceConvar))
CreateTimer(3.0, CreateMessage, client);
}

Yeah the problem is with OnClientPostAdminCheck(). There is not guarantee the database is going to be connected in time for this forward. Just add a boolean to exit the function if the database is not connected. This is a relatively simple fix.

2

RTD is dead?

Could you post a link to the plugin and the error from your sourcemod error log?

10

Hookevent "tank_killed" not working (VS or campaign)

GetClientOfUserId() returns 0 if the userid is invalid. You need to check this after calling it.

Add this constant at the top of your program, to clearly label what 0 means.

#define INVALID_USERID 0

Add this check at the top of your Event_PlayerDeath function after retrieving the victim and killer.

// Verify the userid of the killer and victim is valid before using it if (killer == INVALID_USERID || victim == INVALID_USERID) { return Plugin_Continue; }

6

Help with [TeamGames] plugin compile

I updated SMLIB for SM 1.10 in the TeamGames zip package above.

Originally posted by Kawi:
Nono I ment compiling the wohle TeamGames package. The TeamGames is just part of the plugin. I will try it out.

TeamGames is one plugin. It is split into 14 different files sp files. It produces 1 smx file. I created a new TeamGames folder for the helper sp files, so it compiles more cleanly.

It is bad practice to put helper files in the root compile directory. It tricks the compiler into thinking there is 14 different plugins. Then increases compile times and produces meaningless errors.

I just updated TeamGames to compile with SM 1.10. Update your server to build 6460 or later.
https://www.sourcemod.net/downloads.php?branch=stable

Then extract this zip to your desktop. Go to the 'compiled' folder to get TeamGames.smx.
http://fastdl.eu.xenogamers.com/junk/TeamGames_1.10.zip

Look at the sourcemod error logs after putting TeamGames.smx in your plugins folder. There may be other plugins (required to successfully operate TeamGames) you'll need to install.

10

Hookevent "tank_killed" not working (VS or campaign)

Try this method to call a taunt when the tank dies.

#define ZOMBIE_CLASS_TANK 8 public void OnPluginStart() { HookEvent("player_death", Event_PlayerDeath, EventHookMode_Pre); } public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast) { int client = GetClientOfUserId(event.GetInt("userid")); // Check if the person who died is a tank if(GetEntProp(client, Prop_Send, "m_zombieClass") == ZOMBIE_CLASS_TANK) { // Check if the tank actually died, and is not just losing control if (GetClientHealth(client) <= 1) { // Call taunt method here int attacker = GetClientOfUserId(event.GetInt("attacker")); } } }

Report this post