I've merged the feature by The Stig to allow you to attack while cloaked. It is on by default.

Could you please make it (at least as an option) that you can't attack while invisible?

That behaviour from the original was balanced

I ended up adding a tweak to my tweaks and fixes mod for this mod to act like the original dead ringer by default: https://steamproxy-script.pipiskins.com/sharedfiles/filedetails/?id=3101810034

If you don’t like some of the tweaks you can just turn them off using the convars listed in the description. If you really want, you could turn off every convar except for the dead ringer tweak.

Hey when is the convar for attacking while invisible coming? being able to fake your death and attack while invisible is pretty overpowered

+1
I'd appreciate it a lot if you could include the pull request by @The Stig in a quick hotfix.
Without that convar we are currently unable to use this addon.

Any chance of just quickly putting my PR in as a hotfix?

That is odd, I am probably not unregistering a hook when I should be. I force call HUDPaint even when the weapon is not active so that you can see it.

Thanks for that!
Also, a minor thing, the classic HUD doesn't seem to go away after you die. It only does so after the next round starts.

I was working on something similar, I will merge your PR. A few more updates I want to do before doing another release

I added the option myself. Have a look at this PR: https://github.com/gmod-workshop/ttt-deadringer/pull/7

Please let me know if you update the mod.

You'll have to add ttt_deadringer_cloak_attack 0 to the list of convars needed in the description for the dead ringer to work like the original version.

I can add an option for this

We have a problem in ttt2 the dead ringer triggers you become invisible but can still continue shooting is that what you want?

Thanks I will update the description

For anyone else wondering how to make this mod work like the old dead ringer, set the following convars:

ttt_deadringer_cloak_reactivate 1
ttt_deadringer_sound_activate_local 0
ttt_deadringer_sound_deactivate_local 0

Amazing, thank you so much!

I've updated the addon based on your comments. You can view the changelog on GitHub cause Steam seems to be upset at me posting so many links

Just the dead ring owner, and thanks for looking into all of this!

When you say locally do you mean so that other players can hear or just the Dead Ringer owner?

I will make these changes today. Odd that no sound is played locally. Possibly more dedicated server vs listen/singleplayer weirdness. I've set up a dedicated server now so I should be able to sort that all out today

Ah screw it, I'll switch over anyway. Hope you're able to make those changes

I've added support for the Pack-a-Punch with this version of the dead ringer; however, I noticed a few differences that I know friends will make a comment on if we switched to this version.

- No sound is played locally for the user when the dead ringer recharges
- The dead ringer now turns itself off after cloaking and uncloaking, rather than staying active. I can see someone getting shot again and complaining why their dead ringer didn't go off again
- The cloak HUD element now shows regardless if you have the dead ringer on or off, the old version used to indicate whether the dead ringer was on by the HUD element only showing when it was

Otherwise this version is a very nice update, the convars and hooks added especially. If you're willing to make those changes or add convars for them, I would definitely switch over to your mod! Keep up the good work!

Gah testing on a local listen server vs a dedicated server makes things so complicated. I need to just set up a dedicated server for testing

thx for the updates. but i have now found a new bug. when you are invisible and change weapon the timer no longer uncloaks you after it get so 0. you will be invisible forever, unless you press righht click

See the full changelog here https://github.com/gmod-workshop/ttt-deadringer/releases/tag/3.0.0

I've made a big update to the addon:

Fixed
- Fixed even more issues with a player's weapons still being visible to other players
- Fixed a player's role being forcibly set when being confirmed
- Fixed weapon think code not being called on clients for listen servers
- Fixed several hooks not being registered properly by ensuring they are registered after the gamemode has loaded

Added
- Added `ttt_deadringer_cloak_transparency`
- Added `ttt_deadringer_cloak_targetid`
- Added `ttt_deadringer_damage_threshold`
- The addon will now fake your role on the scoreboard while you are cloaked if your body is confirmed
- Added some help test for TTT and TTT2 do show what the primary and secondary buttons do

Changed
- Renamed `ttt_deadringer_chargetime` to `ttt_deadringer_cloak_cooldown` to be more consistent with the new transparency convar
- Renamed `ttt_deadringer_cloaktime` to `ttt_deadringer_cloak_duration` to be more consistent with other convars
- Renamed `ttt_deadringer_cloaktime_reuse` to `ttt_deadringer_cloak_reuse` to be more consistent with other convars

Oh I didn't understand what you meant by changing role, I see now. Ok I will fix that right now

We tried you new patch on our server and the new changes seem all fine. The only problem is, when the detective gets cloaked you can still see his detective hat, but thats no problem if you deactivate the hat for him. And the "confirm death" feature still changes you role to the corpses one.

@Hegelus I can't seem to reproduce the issue where other players aren't here the uncloak sound

Fixed the issue where a cloaked player's weapons were not invisible

I've fixed the issue regarding the ammo pickup sound being played when purchasing the Dead Ringer

These changes are kind of a first pass, so I will probably be tweaking them a bit in the next few days

Changed ttt_deadringer_corpse_confirm
ttt_deadringer_corpse_confirm is now off by default, if you previously had this on I highly recommend changing this to off in the TTT2 settings. This will prevent corpses from automatically being confirmed on the scoreboard, which can cause some issues. Please only turn this on if you like confusing your players

New Setting ttt_deadringer_corpse_mode

Ok I have removed the ttt_deadringer_corpse_role setting in favor of a new ttt_deadringer_corpse_mode setting.

By default (ttt_deadringer_corpse_mode = 0), for TTT2, bodies will display as 'Fake'. The Dead Ringer is powerful enough as is so I think be default exposing the body as fake balances it a bit more.

Changing this setting to 1 will display the player's REAL role on the corpse. A setting of 2 will spoof the player's role to be innocent.

Keep in mind this setting applies to non-public roles only. If your role is visible to everyone by default (like Detective) then the corpse will always show your real role.

when you are invisible after getting shot i noticed that the weapon gets shown but only after you change weapon while being invisible. you might want to look into that^^

And you can hear a little sound, when someone buys the dead ringer, like he picks up ammunition. Also, the other peoples don't hear a sound if the dead ringer gets activated.

Basically, the addon works now and shows you as an innocent, thanks for the fix. But if you activate the feature "confirm death", I think you mean on the scoreboard, you will change the role to innocent, no matter if you are traitor, detective or jackal.

When ttt_deadringer_corpse_role is 0 a fake role (innocent) will be displayed on the corpse instead of the real role.

When ttt_deadringer_corpse_confirm is 1, the player's role (fake or real depending on the setting above) will be confirmed. This setting only applies to TTT2 as TTT already seems to do this?

Added two new settings based on a request from Hegelus:

ttt_deadringer_corpse_role (def: 0) - Determines if a player's real role or a fake innocent role will be shown on the corpse

ttt_deadringer_corpse_confirm (def: 1) - Determines if the fake corpse will confirm the player's role when checked. This may be used in tandem with ttt_deadringer_corpse_role to confirm fake/real roles

Nice, thank you.

Thanks to EntranceJew there should now be proper settings support for the Deadringer in the equipment menu in TTT2

TTT2. Thanks.

Are you on TTT or TTT2? I can take a look this week

When your corpse gets confirmed, the color that is shown is red, but it says Innocent. Also, the player is not shown as confirmed in the scoreboard. Would be nice if there is an option to change these things.

I searched the discord and the only thing I can find is that the ULX port panel doesn't display them correctly. This doesn't mean that they are not saved. Also it does work if you use native TTT2 menu support

This was literally discussed on the Discord

convars not saving is not a TTT2 issue

Ah, ok. Good to know.
Thanks for the information.

@mexikoedi Unfortunately the convar issue is an issue with TTT2 itself currently. I cannot fix it. You can discuss on the Discord server for TTT2 where they are tracking this issue

I am looking into fixing the weapon issue and convars issue